fix: consider basePath when generating slide URLs#2384
Open
coaxial wants to merge 1 commit intoslidevjs:mainfrom
Open
fix: consider basePath when generating slide URLs#2384coaxial wants to merge 1 commit intoslidevjs:mainfrom
coaxial wants to merge 1 commit intoslidevjs:mainfrom
Conversation
❌ Deploy Preview for slidev failed.
|
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
antfu
reviewed
Nov 27, 2025
| import type { ResolvedFontOptions, SlideInfo, SlideRoute } from '@slidev/types' | ||
| import { relative, resolve } from 'node:path' | ||
| import { slash } from '@antfu/utils' | ||
| import { getSlidePath } from '@slidev/client/logic/slides' |
Member
There was a problem hiding this comment.
This is in client environment that relies on virtual modules; we can't directly test it in this file like this. We might want to extract this logic to test spareately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This fixes an issue with the presenter when using
build --base=/path/where the presenter will instead generate slide links as/<slide number>instead of/path/<slide number>.I've added a test as well but getting this error when trying to run the test suite:
I haven't changed this import and without my patch (i.e. just after cloning), the tests run fine.